Count the frequency of words in a file using a hash table by MinyazevR · Pull Request #66 · MinyazevR/Homework-1-sem

MinyazevR · 2021-11-27T21:59:21Z

No description provided.

New singly linked list

added a function to count the number of duplicate elements

… into FrequencyOfOccurrenceOfWords

yurii-litvinov

Не работает совсем :) У Вас, наверное, тоже. Можно было спросить, почему :)

yurii-litvinov · 2021-12-04T17:35:11Z

Homework № 9/SinglyLinkedListForHashTable/SinglyLinkedListForHashTable.sln

Вообще, .sln описывает целую программную систему. У Вас на каждый модуль свой .sln, что совершенно не нужно. Придерживайтесь принципа "Одна задача --- один .sln-файл", за исключением разве что кода, переиспользуемого между несколькими задачами.

Homework № 9/HashTable/HashTable/HashTable.c

yurii-litvinov · 2021-12-04T17:41:40Z

Homework № 9/HashTable/HashTable/HashTable.c

Это можно было унифицировать с createTable, передавая туда начальный размер таблицы. Кстати, библиотечные словари во многих языках так и делают, принимают желаемый начальный размер в конструктор.

yurii-litvinov · 2021-12-04T17:45:33Z

Homework № 9/HashTable/HashTable/HashTable.c

Лучше > 1

yurii-litvinov · 2021-12-04T17:46:16Z

Homework № 9/HashTable/HashTable/HashTable.c

Suggested change

int numberOf�ompletedBuckets = 0;

int numberOfCompletedBuckets = 0;

yurii-litvinov · 2021-12-04T17:48:55Z

...№ 9/SinglyLinkedListForHashTable/SinglyLinkedListForHashTable/SinglyLinkedListForHashTable.c

Хеш-таблице tail не нужен, потому что список в среднем будет из одного элемента. Раз у Вас всё равно специализированный список, то можно и убрать. Это и код упростит

Homework № 9/HashTable/HashTable/HashTable.c

yurii-litvinov · 2021-12-04T17:51:21Z

...№ 9/SinglyLinkedListForHashTable/SinglyLinkedListForHashTable/SinglyLinkedListForHashTable.c

Эта штука вроде вообще не нужна теперь

yurii-litvinov · 2021-12-04T17:52:20Z

...№ 9/SinglyLinkedListForHashTable/SinglyLinkedListForHashTable/SinglyLinkedListForHashTable.c

Так лучше было бы назвать не head, а element или что-то такое. Это ведь голова списка только до первого head = head->next;

Homework № 9/FrequencyOfOccurrenceOfWords/FrequencyOfOccurrenceOfWords/ReadFile.c

yurii-litvinov

Окей, зачтена

yurii-litvinov · 2021-12-23T17:39:34Z

Homework № 9/HashTable/HashTable/HashTable.c

numberOfSegments лучше

yurii-litvinov · 2021-12-23T17:43:16Z

Homework № 9/HashTable/HashTable/HashTable.h

yurii-litvinov · 2021-12-23T17:43:53Z

...№ 9/SinglyLinkedListForHashTable/SinglyLinkedListForHashTable/SinglyLinkedListForHashTable.c

Suggested change

free(element);

}

free(element);

}

yurii-litvinov · 2021-12-23T17:44:59Z

Homework № 9/HashTable/HashTable/HashTable.c

Ну, по-хорошему если resize не отработал, то стоит старый table не портить — транзакционность. Но ладно :)

yurii-litvinov · 2021-12-23T17:46:14Z

Homework № 9/HashTable/HashTable/HashTable.c

+            maximumListLength = listLength;
+        }
+    }
+    printf("maximum list lenght = %d\n", maximumListLength);


Не поправлено :)

MinyazevR and others added 16 commits November 27, 2021 16:11

a list has been written to implement a hash table

fa4fefe

removed unnecessary code

4b98d8b

writing basic functions for working with a hash table

f5f3c42

writing basic functions for working with a hash table

823c97c

Merge pull request #63 from MinyazevR/NewSinglyLinkedList

e20f209

New singly linked list

the basic functions for working with a hash table are written

c2ecc54

work has been done with the file

03c083f

added a function to count the number of duplicate elements

6f63967

Merge pull request #64 from MinyazevR/NewSinglyLinkedList

3900609

added a function to count the number of duplicate elements

Added comments

dd937c5

Merge branch 'HashTable' of https://github.com/MinyazevR/Homework-1-sem…

9d9c881

… into FrequencyOfOccurrenceOfWords

Added comments

b8c7f28

changed the function to expand the size of the array

8224d00

commit

6e4416d

Merge branch 'HashTable' of https://github.com/MinyazevR/Homework-1-sem…

339d6b9

… into FrequencyOfOccurrenceOfWords

trying to write a function to add an element

bb3dc4d

yurii-litvinov suggested changes Dec 4, 2021

View reviewed changes

MinyazevR added 5 commits December 5, 2021 15:49

changing the functions for working with the list

eeb8fd4

changing functions to work with a hash table

48247b9

changing functions to work with a hash table

63cb7e2

changing the shortcomings in the functions for the hash table

1ed2ace

changed the function for expanding the hash table

5d5eb34

yurii-litvinov approved these changes Dec 23, 2021

View reviewed changes

	int numberOf�ompletedBuckets = 0;
	int numberOfCompletedBuckets = 0;

-    free(element);
-}
+    free(element);
+}

Conversation

MinyazevR commented Nov 27, 2021

Uh oh!

yurii-litvinov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

yurii-litvinov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants